Metals and non metals are of various colours.
It depends upon the colour that they reflect after absorption of light.
Mostly all metals have a shining lustre and of silver-grey tone. Some metals that are coloured are: copper (dark yellow) , gold, silver, iron (silver-grey) etc.
Non metals are dull in appearance. Some coloured non metals are: Sulphur (yellow), bromine (reddish-brown), chlorine (yellow-green).